[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/5] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core

Patchwork patchwork at emeril.freedesktop.org
Mon Oct 7 09:25:50 UTC 2019


== Series Details ==

Series: series starting with [v2,1/5] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core
URL   : https://patchwork.freedesktop.org/series/67674/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
60a6a58e3c4f drm/i915: Allow i915 to manage the vma offset nodes instead of drm core
-:348: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#348: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:661:
+
+	}

-:518: CHECK:LINE_SPACING: Please don't use multiple blank lines
#518: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:573:
 
+

total: 0 errors, 0 warnings, 2 checks, 597 lines checked
9e7d9a57676e drm/i915: define HAS_MAPPABLE_APERTURE
-:20: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'dev_priv' may be better as '(dev_priv)' to avoid precedence issues
#20: FILE: drivers/gpu/drm/i915/i915_drv.h:2083:
+#define HAS_MAPPABLE_APERTURE(dev_priv) (dev_priv->ggtt.mappable_end > 0)

total: 0 errors, 0 warnings, 1 checks, 8 lines checked
c21116f3f492 drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET
-:129: WARNING:LONG_LINE: line over 100 characters
#129: FILE: include/uapi/drm/i915_drm.h:425:
+#define DRM_IOCTL_I915_GEM_MMAP_OFFSET		DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_MMAP_OFFSET, struct drm_i915_gem_mmap_offset)

total: 0 errors, 1 warnings, 0 checks, 129 lines checked
5f8488a031fe drm/i915: cpu-map based dumb buffers
-:25: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#25: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:574:
+i915_gem_mmap_dumb(struct drm_file *file,
+		  struct drm_device *dev,

-:60: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#60: FILE: drivers/gpu/drm/i915/i915_drv.h:2282:
+int i915_gem_mmap_dumb(struct drm_file *file_priv, struct drm_device *dev,
+		      u32 handle, u64 *offset);

total: 0 errors, 0 warnings, 2 checks, 34 lines checked
98fde088e745 drm/i915: Add cpu fault handler for mmap_offset



More information about the Intel-gfx mailing list