[Intel-gfx] [PATCH v7 0/3] CRTC background color

Matt Roper matthew.d.roper at intel.com
Wed Oct 9 21:27:41 UTC 2019


On Wed, Oct 09, 2019 at 05:01:20PM -0400, Daniele Castagna wrote:
> On Wed, Oct 9, 2019 at 1:34 PM Matt Roper <matthew.d.roper at intel.com> wrote:
> >
> > The previous version of this series was posted in February here:
> >         https://lists.freedesktop.org/archives/dri-devel/2019-February/208068.html
> >
> > Right before we merged this in February Maarten noticed that we should
> > be setting up the initial property state in a CRTC reset function (which
> > didn't exist yet) instead of when the property was attached.  Maarten
> > landed the CRTC reset functionality a week or two later, but I was busy
> > with travel and other work at the time, so revisiting and rebasing this
> > background color series fell through the cracks and I'm just getting
> > back to it now.
> >
> > Userspace consumer is chromeos; these are the links the ChromeOS folks
> > gave me back in February:
> >   https://chromium-review.googlesource.com/c/chromium/src/+/1278858
> >   https://chromium-review.googlesource.com/c/chromiumos/platform/drm-tests/+/1241436
> 
> Please note that the current state of the background color on Chrome
> OS side is that while the property plumbing landed, the property is
> currently not used by the compositor and no one is working on making
> that happen.

Hmm, in that case it sounds like we probably don't actually have enough
userspace support yet to justify merging the kernel changes at this
time.  I'm not too familiar with Chrome OS' userspace stack; is the rest
of the work to actually make use of ozone stuff in the links above a
heavy lift?  Is it something someone is likely to work on that once
they're freed up from other tasks or is there just not enough benefit to
justify the effort of utilizing it at the compositor level right now?


Matt

> The kernel patches have not landed on the ChromeOS kernel either.
> 
> 
> >
> >
> > IGT is still the same as posted in February:
> >   https://lists.freedesktop.org/archives/igt-dev/2019-February/009637.html
> >
> > Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> >
> > Matt Roper (3):
> >   drm: Add CRTC background color property
> >   drm/i915/gen9+: Add support for pipe background color
> >   drm/i915: Add background color hardware readout and state check
> >
> >  drivers/gpu/drm/drm_atomic_state_helper.c    |  4 +-
> >  drivers/gpu/drm/drm_atomic_uapi.c            |  4 ++
> >  drivers/gpu/drm/drm_blend.c                  | 35 +++++++++++++--
> >  drivers/gpu/drm/drm_mode_config.c            |  6 +++
> >  drivers/gpu/drm/i915/display/intel_color.c   | 11 +++--
> >  drivers/gpu/drm/i915/display/intel_display.c | 45 ++++++++++++++++++++
> >  drivers/gpu/drm/i915/i915_debugfs.c          |  9 ++++
> >  include/drm/drm_blend.h                      |  1 +
> >  include/drm/drm_crtc.h                       | 12 ++++++
> >  include/drm/drm_mode_config.h                |  5 +++
> >  include/uapi/drm/drm_mode.h                  | 28 ++++++++++++
> >  11 files changed, 153 insertions(+), 7 deletions(-)
> >
> > --
> > 2.21.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795


More information about the Intel-gfx mailing list