[Intel-gfx] [PATCH] drm/dp-mst: Drop connection_mutex check

Lyude Paul lyude at redhat.com
Wed Oct 9 22:46:38 UTC 2019


oh, completely forgot about this one

Reviewed-by: Lyude Paul <lyude at redhat.com>

On Thu, 2019-10-10 at 00:41 +0200, Daniel Vetter wrote:
> Private atomic objects have grown their own locking with
> 
> commit b962a12050a387e4bbf3a48745afe1d29d396b0d
> Author: Rob Clark <robdclark at gmail.com>
> Date:   Mon Oct 22 14:31:22 2018 +0200
> 
>     drm/atomic: integrate modeset lock with private objects
> 
> which means we're no longer relying on connection_mutex for mst state
> locking needs.
> 
> Cc: Lyude Paul <lyude at redhat.com>
> Cc: Sean Paul <sean at poorly.run>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 6b14b63b8d62..9364e4f42975 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -4186,7 +4186,6 @@ struct drm_dp_mst_topology_state
> *drm_atomic_get_mst_topology_state(struct drm_a
>  {
>  	struct drm_device *dev = mgr->dev;
>  
> -	WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
>  	return
> to_dp_mst_topology_state(drm_atomic_get_private_obj_state(state, &mgr-
> >base));
>  }
>  EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);
-- 
Cheers,
	Lyude Paul



More information about the Intel-gfx mailing list