[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv (rev2)

[Lucas De Marchi]

On Wed, Oct 09, 2019 at 10:37:21PM +0000, Patchwork wrote:
>== Series Details ==
>
>Series: series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv (rev2)
>URL   : https://patchwork.freedesktop.org/series/67799/
>State : warning
>
>== Summary ==
>
>$ dim checkpatch origin/drm-tip
>7da5381e3ab8 drm/i915: Move SAGV block time to dev_priv
>-:63: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
>#63: FILE: drivers/gpu/drm/i915/intel_pm.c:3657:
>+		return;
>+	} else {

I agree, it's one of my pet peeves, but i915's codebase doesn't:
"if ladders" with returns inside are used all over the place.

Lucas De Marchi

>
>total: 0 errors, 1 warnings, 0 checks, 69 lines checked
>cc743a676c3a drm/i915/tgl: Read SAGV block time from PCODE
>