[Intel-gfx] [bug report] drm/i915/selftests: Exercise context switching in parallel

Chris Wilson chris at chris-wilson.co.uk
Fri Oct 11 11:58:22 UTC 2019


Quoting Dan Carpenter (2019-10-11 12:42:09)
> Hello Chris Wilson,
> 
> This is a semi-automatic email about new static checker warnings.
> 
> The patch 50d16d44cce4: "drm/i915/selftests: Exercise context 
> switching in parallel" from Sep 30, 2019, leads to the following 
> Smatch complaint:
> 
>     drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:349 live_parallel_switch()
>     error: we previously assumed 'data' could be null (see line 263)
> 
> drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
>    257          }
>    258  
>    259          engines = i915_gem_context_lock_engines(ctx);
>    260          count = engines->num_engines;
>    261  
>    262          data = kcalloc(count, sizeof(*data), GFP_KERNEL);
>    263          if (!data) {
>    264                  i915_gem_context_unlock_engines(ctx);
>    265                  err = -ENOMEM;
>    266                  goto out;
>                         ^^^^^^^^
> goto out is always a sign of troubled times ahead...

Has been upgraded to out_file with claims of fewer burnt toast.
-Chris


More information about the Intel-gfx mailing list