[Intel-gfx] [PATCH] drm/i915/display: Squelch kerneldoc warnings

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Mon Oct 14 09:44:55 UTC 2019


On 12/10/2019 09:02, Chris Wilson wrote:
> Just a parameter rename,
> 
> drivers/gpu/drm/i915/display/intel_display.c:14425: warning: Function parameter or member '_new_plane_state' not described in 'intel_prepare_plane_fb'
> drivers/gpu/drm/i915/display/intel_display.c:14425: warning: Excess function parameter 'new_state' description in 'intel_prepare_plane_fb'
> drivers/gpu/drm/i915/display/intel_display.c:14534: warning: Function parameter or member '_old_plane_state' not described in 'intel_cleanup_plane_fb'
> drivers/gpu/drm/i915/display/intel_display.c:14534: warning: Excess function parameter 'old_state' description in 'intel_cleanup_plane_fb'
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Cc: Matt Roper <matthew.d.roper at intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_display.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index a146ec02a0c1..3cf39fc153b3 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -14410,7 +14410,7 @@ static void fb_obj_bump_render_priority(struct drm_i915_gem_object *obj)
>   /**
>    * intel_prepare_plane_fb - Prepare fb for usage on plane
>    * @plane: drm plane to prepare for
> - * @new_state: the plane state being prepared
> + * @_new_plane_state: the plane state being prepared
>    *
>    * Prepares a framebuffer for usage on a display plane.  Generally this
>    * involves pinning the underlying object and updating the frontbuffer tracking
> @@ -14524,7 +14524,7 @@ intel_prepare_plane_fb(struct drm_plane *plane,
>   /**
>    * intel_cleanup_plane_fb - Cleans up an fb after plane use
>    * @plane: drm plane to clean up for
> - * @old_state: the state from the previous modeset
> + * @_old_plane_state: the state from the previous modeset
>    *
>    * Cleans up a framebuffer that has just been removed from a plane.
>    */
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko


More information about the Intel-gfx mailing list