[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/5] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core

Patchwork patchwork at emeril.freedesktop.org
Tue Oct 15 09:05:44 UTC 2019


== Series Details ==

Series: series starting with [v3,1/5] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core
URL   : https://patchwork.freedesktop.org/series/68010/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
020865777f8a drm/i915: Allow i915 to manage the vma offset nodes instead of drm core
-:337: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#337: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:648:
+
+	}

-:503: CHECK:LINE_SPACING: Please don't use multiple blank lines
#503: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:573:
 
+

total: 0 errors, 0 warnings, 2 checks, 559 lines checked
6fdb184775a4 drm/i915: define HAS_MAPPABLE_APERTURE
-:20: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'dev_priv' may be better as '(dev_priv)' to avoid precedence issues
#20: FILE: drivers/gpu/drm/i915/i915_drv.h:1738:
+#define HAS_MAPPABLE_APERTURE(dev_priv) (dev_priv->ggtt.mappable_end > 0)

total: 0 errors, 0 warnings, 1 checks, 8 lines checked
c3709716f57f drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET
-:118: WARNING:LONG_LINE: line over 100 characters
#118: FILE: include/uapi/drm/i915_drm.h:397:
+#define DRM_IOCTL_I915_GEM_MMAP_GTT	DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_MMAP_GTT, struct drm_i915_gem_mmap_offset)

total: 0 errors, 1 warnings, 0 checks, 111 lines checked
3fa09534bd30 drm/i915: cpu-map based dumb buffers
-:25: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#25: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:568:
+i915_gem_mmap_dumb(struct drm_file *file,
+		  struct drm_device *dev,

-:60: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#60: FILE: drivers/gpu/drm/i915/i915_drv.h:1937:
+int i915_gem_mmap_dumb(struct drm_file *file_priv, struct drm_device *dev,
+		      u32 handle, u64 *offset);

total: 0 errors, 0 warnings, 2 checks, 34 lines checked
e932227102bb drm/i915: Add cpu fault handler for mmap_offset



More information about the Intel-gfx mailing list