[Intel-gfx] [PATCH] drm/i915: Remove leftover vma->obj->pages_pin_count on insert/remove

Matthew Auld matthew.auld at intel.com
Tue Oct 15 10:22:20 UTC 2019


On 15/10/2019 11:01, Chris Wilson wrote:
> We now do the page pin count upfront in vma_get_pages/vma_put_pages, so
> that we do the allocations before we enter the vm->mutex. Then our vma
> page references are tracking in vma->pages_count and the extra
> obj->pages_pin_count being performed in i915_vma_insert/i915_vma_remove
> is redundant, and worse throws off the shrinker's logic on when it can
> free an object by unbinding it.
> 
Could you also add Reported-by: Daniele Ceraolo Spurio 
<daniele.ceraolospurio at intel.com>

> Reported-by: Matthew Auld <matthew.auld at intel.com>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld at intel.com>
Reviewed-by: Matthew Auld <matthew.auld at intel.com>


More information about the Intel-gfx mailing list