[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Refactor Gen11+ SAGV support

Patchwork patchwork at emeril.freedesktop.org
Tue Oct 15 16:01:46 UTC 2019


== Series Details ==

Series: Refactor Gen11+ SAGV support
URL   : https://patchwork.freedesktop.org/series/68028/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
248cbaf741d0 drm/i915: Refactor intel_can_enable_sagv
-:33: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#33: FILE: drivers/gpu/drm/i915/intel_pm.c:3802:
 		if (skl_needs_memory_bw_wa(dev_priv) &&
[...]
+				latency += 15;

-:66: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#66: FILE: drivers/gpu/drm/i915/intel_pm.c:3839:
+	for_each_new_intel_crtc_in_state(state, crtc,
+					     new_crtc_state, i) {

-:67: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#67: FILE: drivers/gpu/drm/i915/intel_pm.c:3840:
+					     new_crtc_state, i) {
+

-:83: ERROR:OPEN_BRACE: that open brace { should be on the previous line
#83: FILE: drivers/gpu/drm/i915/intel_pm.c:3856:
+			for (level = ilk_wm_max_level(dev_priv);
+			     !wm->wm[level].plane_en; --level)
+			     { }

total: 1 errors, 1 warnings, 2 checks, 91 lines checked
4b87f530f108 drm/i915: Restrict qgv points which don't have enough bandwidth.
-:124: CHECK:LINE_SPACING: Please don't use multiple blank lines
#124: FILE: drivers/gpu/drm/i915/display/intel_bw.c:138:
+
+

-:329: CHECK:BRACES: braces {} should be used on all arms of this statement
#329: FILE: drivers/gpu/drm/i915/display/intel_display.c:14208:
+	if (INTEL_GEN(dev_priv) < 11) {
[...]
+	else
[...]

-:333: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#333: FILE: drivers/gpu/drm/i915/display/intel_display.c:14212:
+	}
+	else

total: 1 errors, 0 warnings, 2 checks, 298 lines checked



More information about the Intel-gfx mailing list