[Intel-gfx] [PATCH 1/2] drm/i915: Make for_each_engine_masked work on intel_gt

Chris Wilson chris at chris-wilson.co.uk
Thu Oct 17 10:00:15 UTC 2019


Quoting Tvrtko Ursulin (2019-10-17 10:44:59)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> Medium term goal is to eliminate the i915->engine[] array and to get there
> we have recently introduced equivalent array in intel_gt. Now we need to
> migrate the code further towards this state.
> 
> This next step is to eliminate usage of i915->engines[] from the
> for_each_engine_masked iterator.
> 
> For this to work we also need to use engine->id as index when populating
> the gt->engine[] array and adjust the default engine set indexing to use
> engine->legacy_idx instead of assuming gt->engines[] indexing.
> 
> v2:
>  * Populate gt->engine[] earlier.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>

I checked all the legacy_idx to make sure there wasn't anything nasty
there, and it all looked okay.

So once we have the early foible sorted out,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list