[Intel-gfx] [PATCH] drm/i915/perf: fix oa config reconfiguration

Chris Wilson chris at chris-wilson.co.uk
Sun Oct 20 09:00:24 UTC 2019


Quoting Lionel Landwerlin (2019-10-19 22:46:47)
> The current logic just reapplies the same configuration already stored
> into stream->oa_config instead of the newly selected one.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Fixes: 7831e9a965ea ("drm/i915/perf: Allow dynamic reconfiguration of the OA stream")
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> ---
> @@ -2895,7 +2896,7 @@ static long i915_perf_config_locked(struct i915_perf_stream *stream,
>                  * When set globally, we use a low priority kernel context,
>                  * so it will effectively take effect when idle.
>                  */
> -               err = emit_oa_config(stream, oa_context(stream));
> +               err = emit_oa_config(stream, config, oa_context(stream));
>                 if (err == 0)
>                         config = xchg(&stream->oa_config, config);

Oh crikey.
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list