[Intel-gfx] [PATCH] drm/i915/selftests: Move uncore fw selftests to operate on intel_gt

Chris Wilson chris at chris-wilson.co.uk
Tue Oct 22 13:54:12 UTC 2019


Quoting Tvrtko Ursulin (2019-10-22 14:44:31)
> 
> On 22/10/2019 14:10, Chris Wilson wrote:
> > Forcewake is the speciality of the GT, so it is natural to run the
> > intel_uncore_forcewake tests over the GT. So pass intel_gt as the
> > parameter to our selftests.
> 
> I had the same urge yesterday but then ended unsure how the display/gt 
> uncore split may affect this on the logical level. So I'll leave the 
> decision to Daniele, he should know better what plans are there.
> 
> On the particular patch only comment is that I would consider one or two 
> i915 locals for better readability.

You don't have the itch for a GT_INFO() yet?
I'll keep piling them up then ;)
-Chris


More information about the Intel-gfx mailing list