[Intel-gfx] [PATCH] drm/i915: Add new CNL PCH ID seen on a CML platform

Souza, Jose jose.souza at intel.com
Tue Oct 22 17:52:18 UTC 2019


On Tue, 2019-10-22 at 12:51 +0300, Imre Deak wrote:
> Atm we don't detect a PCH with PCI ID 0xA3C1 which showed up now on a
> CML
> platform. We don't have the official assignment of the PCH PCI IDs,
> but
> this looks like a CNP which was already used on CML platforms. Let's
> add
> the new ID->PCH type mapping accordingly.

Looks right...

Reviewed-by: José Roberto de Souza <jose.souza at intel.com>

> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112051
> Reported-and-tested-by: Cyrus <cyrus.lien at canonical.com>
> Cc: Cyrus <cyrus.lien at canonical.com>
> Signed-off-by: Imre Deak <imre.deak at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pch.c | 1 +
>  drivers/gpu/drm/i915/intel_pch.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pch.c
> b/drivers/gpu/drm/i915/intel_pch.c
> index 1035d3d46fd8..43f23820d032 100644
> --- a/drivers/gpu/drm/i915/intel_pch.c
> +++ b/drivers/gpu/drm/i915/intel_pch.c
> @@ -61,6 +61,7 @@ intel_pch_type(const struct drm_i915_private
> *dev_priv, unsigned short id)
>  		/* KBP is SPT compatible */
>  		return PCH_SPT;
>  	case INTEL_PCH_CNP_DEVICE_ID_TYPE:
> +	case INTEL_PCH_CNP2_DEVICE_ID_TYPE:
>  		DRM_DEBUG_KMS("Found Cannon Lake PCH (CNP)\n");
>  		WARN_ON(!IS_CANNONLAKE(dev_priv) &&
> !IS_COFFEELAKE(dev_priv));
>  		return PCH_CNP;
> diff --git a/drivers/gpu/drm/i915/intel_pch.h
> b/drivers/gpu/drm/i915/intel_pch.h
> index f4dc18c34291..1115c6a0522c 100644
> --- a/drivers/gpu/drm/i915/intel_pch.h
> +++ b/drivers/gpu/drm/i915/intel_pch.h
> @@ -40,6 +40,7 @@ enum intel_pch {
>  #define INTEL_PCH_SPT_LP_DEVICE_ID_TYPE		0x9D00
>  #define INTEL_PCH_KBP_DEVICE_ID_TYPE		0xA280
>  #define INTEL_PCH_CNP_DEVICE_ID_TYPE		0xA300
> +#define INTEL_PCH_CNP2_DEVICE_ID_TYPE		0xA380
>  #define INTEL_PCH_CNP_LP_DEVICE_ID_TYPE		0x9D80
>  #define INTEL_PCH_CMP_DEVICE_ID_TYPE		0x0280
>  #define INTEL_PCH_CMP2_DEVICE_ID_TYPE		0x0680


More information about the Intel-gfx mailing list