[Intel-gfx] [PATCH 1/2] drm/i915/uc: define GuC and HuC binaries for TGL

Michal Wajdeczko michal.wajdeczko at intel.com
Sat Oct 26 10:44:39 UTC 2019


On Sat, 26 Oct 2019 02:35:06 +0200, Daniele Ceraolo Spurio  
<daniele.ceraolospurio at intel.com> wrote:

> GuC 35.2.0 and HuC 7.0.3 are the first production releases for TGL.
> GuC 35.2 for gen12 is interface-compatible with 33.0 on older gens,
> because the differences are related to additional blocks/commands in
> the interface to support new Gen12 features. These parts of the
> interface will be added when the relevant features are enabled.
>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa at intel.com>
> ---
>  drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c  
> b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> index bb4889d2346d..09201f12f5cc 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> @@ -37,8 +37,13 @@ void intel_uc_fw_change_status(struct intel_uc_fw  
> *uc_fw,
>  /*
>   * List of required GuC and HuC binaries per-platform.
>   * Must be ordered based on platform + revid, from newer to older.
> + *
> + * TGL 35.2 is interface-compatible with 33.0 for previous gens. The  
> deltas
> + * between 33.0 and 35.2 are only related to new additions to support  
> new gen12
> + * features.

nit: s/gen12/Gen12 (same for "gens"), here and in the commit message

Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>

Thanks,
Michal


More information about the Intel-gfx mailing list