[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] drm/i915: Fix i845/i865 cursor width

Patchwork patchwork at emeril.freedesktop.org
Mon Oct 28 14:43:10 UTC 2019


== Series Details ==

Series: series starting with [1/6] drm/i915: Fix i845/i865 cursor width
URL   : https://patchwork.freedesktop.org/series/68646/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
4da018f49855 drm/i915: Fix i845/i865 cursor width
19cde21752fa drm/i915: Fix max cursor size for i915g/gm
e8bd89048c9a drm/i915: Fix overlay colorkey for 30bpp and 8bpp
-:26: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'c' - possible side-effects?
#26: FILE: drivers/gpu/drm/i915/display/intel_overlay.c:105:
+#define RGB30_TO_COLORKEY(c) \
+	(((c & 0x3FC00000) >> 6) | ((c & 0x000FF000) >> 4) | ((c & 0x000003FC) >> 2))

-:26: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'c' may be better as '(c)' to avoid precedence issues
#26: FILE: drivers/gpu/drm/i915/display/intel_overlay.c:105:
+#define RGB30_TO_COLORKEY(c) \
+	(((c & 0x3FC00000) >> 6) | ((c & 0x000FF000) >> 4) | ((c & 0x000003FC) >> 2))

-:32: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'c' - possible side-effects?
#32: FILE: drivers/gpu/drm/i915/display/intel_overlay.c:111:
+#define RGB8I_TO_COLORKEY(c) \
+	(((c & 0xFF) << 16) | ((c & 0XFF) << 8) | ((c & 0xFF) << 0))

-:32: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'c' may be better as '(c)' to avoid precedence issues
#32: FILE: drivers/gpu/drm/i915/display/intel_overlay.c:111:
+#define RGB8I_TO_COLORKEY(c) \
+	(((c & 0xFF) << 16) | ((c & 0XFF) << 8) | ((c & 0xFF) << 0))

total: 0 errors, 0 warnings, 4 checks, 37 lines checked
db0e1a02849f drm/i915: Configure overlay cc_out precision based on crtc gamma config
c7bd1d944a4b drm/i915: Enable pipe gamma for the overlay
ff2e006cf58b drm/i915: Protect overlay colorkey macro arguments



More information about the Intel-gfx mailing list