[Intel-gfx] [PATCH] drm/i915/execlists: Use vfunc to check engine submission mode

Chris Wilson chris at chris-wilson.co.uk
Mon Oct 28 15:40:31 UTC 2019


Quoting Michal Wajdeczko (2019-10-28 14:22:29)
> On Mon, 28 Oct 2019 14:09:05 +0100, Chris Wilson  
> <chris at chris-wilson.co.uk> wrote:
> 
> > Quoting Michal Wajdeczko (2019-10-28 12:57:03)
> >> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.h  
> >> b/drivers/gpu/drm/i915/gt/intel_lrc.h
> >> index 99dc576a4e25..23dde9083349 100644
> >> --- a/drivers/gpu/drm/i915/gt/intel_lrc.h
> >> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.h
> >> @@ -145,4 +145,6 @@ struct intel_engine_cs *
> >>  intel_virtual_engine_get_sibling(struct intel_engine_cs *engine,
> >>                                  unsigned int sibling);
> >>
> >> +bool intel_engine_in_execlists_submission_mode(struct intel_engine_cs  
> >> *engine);
> >
> > Planning to use it outside?
> 
> Yes, there are few places where global USES_GUC_SUBMISSION(i915) is used,
> and some of them can be replaced by in_execlists_submission_mode(e) right
> away (i915_perf.c).

Aye, perf looks like a good candidate to put this to immediate use. Care
to include that with
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list