[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3.

Patchwork patchwork at emeril.freedesktop.org
Wed Oct 30 14:41:40 UTC 2019


== Series Details ==

Series: series starting with [CI,01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3.
URL   : https://patchwork.freedesktop.org/series/68775/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
82ecaad3eafe drm/i915: Handle a few more cases for crtc hw/uapi split, v3.
e96549d2f605 drm/i915: Add aliases for uapi and hw to crtc_state
-:67: WARNING:LONG_LINE: line over 100 characters
#67: FILE: drivers/gpu/drm/i915/display/intel_display.h:453:
+			      to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base))))

total: 0 errors, 1 warnings, 0 checks, 83 lines checked
767bd125ad64 drm/i915: Perform manual conversions for crtc uapi/hw split, v2.
59dc3f8575d8 drm/i915: Perform automated conversions for crtc uapi/hw split, base -> hw.
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10: 
Split up crtc_state->base to hw where appropriate. This is done using the following patch:

-:1423: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1423: FILE: drivers/gpu/drm/i915/display/intel_display.c:17296:
+		crtc_state->hw.active = crtc_state->hw.enable =

total: 0 errors, 1 warnings, 1 checks, 2068 lines checked
5a396a2373ce drm/i915: Perform automated conversions for crtc uapi/hw split, base -> uapi.
-:2400: ERROR:CODE_INDENT: code indent should use tabs where possible
#2400: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:211:
+^I^I^I^I          new_crtc_state->uapi.event);$

-:2400: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2400: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:211:
+		drm_crtc_arm_vblank_event(&crtc->base,
+				          new_crtc_state->uapi.event);

total: 1 errors, 0 warnings, 1 checks, 2552 lines checked
bf5ed354107d drm/i915: Complete crtc hw/uapi split, v5.
-:15: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#15: 
- Clear crtc_state->hw on disable, instead of using clear_intel_crtc_state().

total: 0 errors, 1 warnings, 0 checks, 236 lines checked
0155a0d5474e drm/i915: Add aliases for uapi and hw to plane_state
-:49: WARNING:LINE_SPACING: Missing a blank line after declarations
#49: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:112:
+	struct intel_plane_state *plane_state = to_intel_plane_state(state);
+	WARN_ON(plane_state->vma);

total: 0 errors, 1 warnings, 0 checks, 59 lines checked
a5ff4f639f56 drm/i915: Perform manual conversions for plane uapi/hw split, v2.
b9466bcd7ab7 drm/i915: Perform automated conversions for plane uapi/hw split, base -> hw.
-:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14: 
identifier x =~ "^(crtc|fb|alpha|pixel_blend_mode|rotation|color_encoding|color_range)$";

-:912: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "plane_state->hw.fb"
#912: FILE: drivers/gpu/drm/i915/intel_pm.c:804:
+		return plane_state->hw.fb != NULL;

total: 0 errors, 1 warnings, 1 checks, 890 lines checked
5eb56542cc9f drm/i915: Perform automated conversions for plane uapi/hw split, base -> uapi.
-:745: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#745: FILE: drivers/gpu/drm/i915/display/intel_display.c:11181:
+		unsigned width = drm_rect_width(&plane_state->uapi.dst);

-:746: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#746: FILE: drivers/gpu/drm/i915/display/intel_display.c:11182:
+		unsigned height = drm_rect_height(&plane_state->uapi.dst);

-:814: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#814: FILE: drivers/gpu/drm/i915/display/intel_display.c:11784:
+		plane_state->uapi.visible = visible = false;

-:1541: WARNING:LONG_LINE: line over 100 characters
#1541: FILE: drivers/gpu/drm/i915/intel_pm.c:3103:
+			(drm_rect_width(&sprstate->uapi.dst) != drm_rect_width(&sprstate->uapi.src) >> 16 ||

-:1542: WARNING:LONG_LINE: line over 100 characters
#1542: FILE: drivers/gpu/drm/i915/intel_pm.c:3104:
+			 drm_rect_height(&sprstate->uapi.dst) != drm_rect_height(&sprstate->uapi.src) >> 16);

total: 0 errors, 4 warnings, 1 checks, 1442 lines checked
458aaa55eea4 drm/i915: Complete plane hw and uapi split, v2.
-:139: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u16' over 'uint16_t'
#139: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:538:
+		uint16_t pixel_blend_mode;

total: 0 errors, 0 warnings, 1 checks, 107 lines checked
c55eecda334c drm/i915: Remove special case slave handling during hw programming, v3.
-:16: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#16: 
- Use the correct color_plane for pre-gen11 by using planar_linked_plane != NULL.

total: 0 errors, 1 warnings, 0 checks, 201 lines checked



More information about the Intel-gfx mailing list