[Intel-gfx] [PATCH 5/5] drm/i915: Defer rc6 shutdown to suspend_late

Andi Shyti andi.shyti at intel.com
Wed Oct 30 23:57:23 UTC 2019


Hi Chris,

On Wed, Oct 30, 2019 at 10:38:27AM +0000, Chris Wilson wrote:
> Currently we shutdown rc6 during i915_gem_resume() but this is called
> during the preparation phase (i915_drm_prepare) for all suspend paths,
> but we only want to shutdown rc6 for S3+. Move the actual shutdown to
> i915_gem_suspend_late().
> 
> We then need to differentiate between suspend targets, to distinguish S0
> (s2idle) where the device is kept awake but needs to be in a low power
> mode (the same as runtime suspend) from the device suspend levels where
> we lose control of HW and so must disable any HW access to dangling
> memory.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111909
> Fixes: c113236718e8 ("drm/i915: Extract GT render sleep (rc6) management")
> Testcase: igt/gem_exec_suspend/power-S0
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Andi Shyti <andi.shyti at intel.com>

Looks OK! Thanks!

Acked-by: Andi Shyti <andi.shyti at intel.com>

Andi


More information about the Intel-gfx mailing list