[Intel-gfx] [PATCH 1/6] drm/i915/display: Move out code to return the digital_port of the aux ch

[kbuild test robot]

Hi "José,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip next-20200331]
[cannot apply to v5.6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jos-Roberto-de-Souza/drm-i915-display-Move-out-code-to-return-the-digital_port-of-the-aux-ch/20200401-094021
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-6) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>

All error/warnings (new ones prefixed by >>):

   drivers/gpu/drm/i915/display/intel_display_power.c: In function 'icl_tc_phy_aux_power_well_enable':
>> drivers/gpu/drm/i915/display/intel_display_power.c:561:40: error: implicit declaration of function 'aux_ch_to_digital_port'; did you mean 'enc_to_dig_port'? [-Werror=implicit-function-declaration]
     struct intel_digital_port *dig_port = aux_ch_to_digital_port(dev_priv, aux_ch);
                                           ^~~~~~~~~~~~~~~~~~~~~~
                                           enc_to_dig_port
>> drivers/gpu/drm/i915/display/intel_display_power.c:561:40: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
>> drivers/gpu/drm/i915/display/intel_display_power.c:564:2: error: too many arguments to function 'icl_tc_port_assert_ref_held'
     icl_tc_port_assert_ref_held(dev_priv, power_well, dig_port);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/i915/display/intel_display_power.c:547:13: note: declared here
    static void icl_tc_port_assert_ref_held(struct drm_i915_private *dev_priv,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/i915/display/intel_display_power.c: In function 'icl_tc_phy_aux_power_well_disable':
   drivers/gpu/drm/i915/display/intel_display_power.c:593:40: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
     struct intel_digital_port *dig_port = aux_ch_to_digital_port(dev_priv, aux_ch);
                                           ^~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/i915/display/intel_display_power.c:595:2: error: too many arguments to function 'icl_tc_port_assert_ref_held'
     icl_tc_port_assert_ref_held(dev_priv, power_well, dig_port);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/i915/display/intel_display_power.c:547:13: note: declared here
    static void icl_tc_port_assert_ref_held(struct drm_i915_private *dev_priv,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +561 drivers/gpu/drm/i915/display/intel_display_power.c

   555	
   556	static void
   557	icl_tc_phy_aux_power_well_enable(struct drm_i915_private *dev_priv,
   558					 struct i915_power_well *power_well)
   559	{
   560		enum aux_ch aux_ch = icl_tc_phy_aux_ch(dev_priv, power_well);
 > 561		struct intel_digital_port *dig_port = aux_ch_to_digital_port(dev_priv, aux_ch);
   562		u32 val;
   563	
 > 564		icl_tc_port_assert_ref_held(dev_priv, power_well, dig_port);
   565	
   566		val = intel_de_read(dev_priv, DP_AUX_CH_CTL(aux_ch));
   567		val &= ~DP_AUX_CH_CTL_TBT_IO;
   568		if (power_well->desc->hsw.is_tc_tbt)
   569			val |= DP_AUX_CH_CTL_TBT_IO;
   570		intel_de_write(dev_priv, DP_AUX_CH_CTL(aux_ch), val);
   571	
   572		hsw_power_well_enable(dev_priv, power_well);
   573	
   574		if (INTEL_GEN(dev_priv) >= 12 && !power_well->desc->hsw.is_tc_tbt) {
   575			enum tc_port tc_port;
   576	
   577			tc_port = TGL_AUX_PW_TO_TC_PORT(power_well->desc->hsw.idx);
   578			intel_de_write(dev_priv, HIP_INDEX_REG(tc_port),
   579				       HIP_INDEX_VAL(tc_port, 0x2));
   580	
   581			if (intel_de_wait_for_set(dev_priv, DKL_CMN_UC_DW_27(tc_port),
   582						  DKL_CMN_UC_DW27_UC_HEALTH, 1))
   583				drm_warn(&dev_priv->drm,
   584					 "Timeout waiting TC uC health\n");
   585		}
   586	}
   587	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 28987 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20200401/5fa9065c/attachment-0001.gz>