[Intel-gfx] [PATCH 02/17] drm/i915/panel: use struct drm_device based logging

Jani Nikula jani.nikula at intel.com
Mon Apr 6 12:44:40 UTC 2020


On Mon, 06 Apr 2020, "Bharadiya,Pankaj" <pankaj.laxminarayan.bharadiya at intel.com> wrote:
> Adding new i915 variable seems to be redundant here since we can 
> directly use "connector->base.dev" for getting struct drm_device
> pointer.

We could. However, struct drm_i915_private *i915 is widely used and
needed throughout the driver, all over the place. I'd rather add i915
now instead of first using connector->base.dev or whatever, and having
someone add i915 at a later time and then converting to &i915->drm.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center


More information about the Intel-gfx mailing list