[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm: report dp downstream port type as a subconnector property

Patchwork patchwork at emeril.freedesktop.org
Tue Apr 7 07:41:10 UTC 2020


== Series Details ==

Series: series starting with [1/5] drm: report dp downstream port type as a subconnector property
URL   : https://patchwork.freedesktop.org/series/75585/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
4bd9a33efdc0 drm: report dp downstream port type as a subconnector property
-:54: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Unknown>
#54: FILE: drivers/gpu/drm/drm_connector.c:847:
+	{ DRM_MODE_SUBCONNECTOR_Unknown,   "Unknown"   }, /* DVI-I, TV-out and DP */

-:76: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_DisplayPort>
#76: FILE: drivers/gpu/drm/drm_connector.c:878:
+	{ DRM_MODE_SUBCONNECTOR_DisplayPort, "DP"        }, /* DP */

-:77: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Wireless>
#77: FILE: drivers/gpu/drm/drm_connector.c:879:
+	{ DRM_MODE_SUBCONNECTOR_Wireless,    "Wireless"  }, /* DP */

-:78: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Native>
#78: FILE: drivers/gpu/drm/drm_connector.c:880:
+	{ DRM_MODE_SUBCONNECTOR_Native,	     "Native"    }, /* DP */

-:119: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#119: FILE: drivers/gpu/drm/drm_connector.c:1311:
+			drm_property_create_enum(connector->dev,
+				DRM_MODE_PROP_IMMUTABLE,

-:152: WARNING:LINE_SPACING: Missing a blank line after declarations
#152: FILE: drivers/gpu/drm/drm_dp_helper.c:608:
+	int type;
+	if (!drm_dp_is_branch(dpcd))

-:213: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#213: FILE: drivers/gpu/drm/drm_dp_helper.c:669:
+	drm_object_property_set_value(&connector->base,
+			connector->dev->mode_config.dp_subconnector_property,

-:298: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Automatic>
#298: FILE: include/uapi/drm/drm_mode.h:335:
+	DRM_MODE_SUBCONNECTOR_Automatic   = 0,  /* DVI-I, TV     */

-:303: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Composite>
#303: FILE: include/uapi/drm/drm_mode.h:340:
+	DRM_MODE_SUBCONNECTOR_Composite   = 5,  /*        TV     */

-:305: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Component>
#305: FILE: include/uapi/drm/drm_mode.h:342:
+	DRM_MODE_SUBCONNECTOR_Component   = 8,  /*        TV     */

total: 0 errors, 1 warnings, 9 checks, 234 lines checked
d2c8d8547c2a drm/i915: utilize subconnector property for DP
2dfa92187ee6 drm/nouveau: utilize subconnector property for DP
-:28: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Unknown>
#28: FILE: drivers/gpu/drm/nouveau/nouveau_connector.c:653:
+		enum drm_mode_subconnector subconnector = DRM_MODE_SUBCONNECTOR_Unknown;

-:33: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#33: FILE: drivers/gpu/drm/nouveau/nouveau_connector.c:658:
+		drm_object_property_set_value(&connector->base,
+			connector->dev->mode_config.dp_subconnector_property,

total: 0 errors, 0 warnings, 2 checks, 53 lines checked
39a32c6dd117 drm/amdgpu: utilize subconnector property for DP through atombios
492358bb545e drm/amdgpu: utilize subconnector property for DP through DisplayManager
-:38: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Native>
#38: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:128:
+		return DRM_MODE_SUBCONNECTOR_Native;

-:49: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Unknown>
#49: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:139:
+		return DRM_MODE_SUBCONNECTOR_Unknown;

-:66: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#66: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:156:
+	drm_object_property_set_value(&connector->base,
+			connector->dev->mode_config.dp_subconnector_property,

total: 0 errors, 0 warnings, 3 checks, 80 lines checked



More information about the Intel-gfx mailing list