[Intel-gfx] [PATCH] drm/i915/selftests: Drop vestigal timeslicing assert

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Wed Apr 8 07:58:45 UTC 2020


On 07/04/2020 23:26, Chris Wilson wrote:
> Since the semaphore interrupt may cause us to yield the timeslice
> immediately, we may cancel the timer before we notice the submission is
> complete. The assertion is no longer valid due to the race with the
> interrupt.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/gt/selftest_lrc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> index 43362b8a5855..57db3d0ffaf2 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> @@ -1073,7 +1073,6 @@ static int live_timeslice_rewind(void *arg)
>   			       engine->name);
>   			goto err;
>   		}
> -		GEM_BUG_ON(!timer_pending(&engine->execlists.timer));
>   
>   		/* ELSP[] = { { A:rq1, A:rq2 }, { B:rq1 } } */
>   		if (i915_request_is_active(rq[A2])) { /* semaphore yielded! */
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko


More information about the Intel-gfx mailing list