[Intel-gfx] [PATCH] drm/i915/selftests: Check for an already completed timeslice

Andi Shyti andi at etezian.org
Fri Apr 10 13:11:07 UTC 2020


Hi Chris,

> With timeslice yielding on a semaphore, we may complete timeslices much
> faster than we were expecting and already have yielded the stuck
> request. Before complaining that timeslicing is not enabled, check that
> we haven't already applied the switch.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/gt/selftest_lrc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> index 616d03506c2c..6f5e35afe1b2 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> @@ -1252,6 +1252,7 @@ static int live_timeslice_queue(void *arg)
>  		} while (READ_ONCE(engine->execlists.pending[0]));
>  
>  		if (!READ_ONCE(engine->execlists.timer.expires) &&
> +		    execlists_active(&engine->execlists) == rq &&
>  		    !i915_request_completed(rq)) {
>  			struct drm_printer p =
>  				drm_info_printer(gt->i915->drm.dev);

Reviewed-by: Andi Shyti <andi.shyti at intel.com>

Thanks,
Andi


More information about the Intel-gfx mailing list