[Intel-gfx] [PATCH 4/4] drm/selftests: selftest for timeline semaphore

[kbuild test robot]

Hi Venkata,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next linus/master v5.6 next-20200410]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Venkata-Sandeep-Dhanalakota/drm-i915-introduce-a-mechanism-to-extend-execbuf2/20200411-031057
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp at intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/selftests/test-drm_timeline_semaphore.c: In function 'igt_forward':
>> drivers/gpu/drm/selftests/test-drm_timeline_semaphore.c:511:1: warning: the frame size of 1568 bytes is larger than 1280 bytes [-Wframe-larger-than=]
     511 | }
         | ^

vim +511 drivers/gpu/drm/selftests/test-drm_timeline_semaphore.c

   433	
   434	static int igt_forward(void *ignored)
   435	{
   436		struct mock_timeline *s[MAX_TIMELINES], *t[MAX_TIMELINES];
   437		struct task_struct *tasks[MAX_THREADS], *tsk;
   438		struct chain_info ci, c[MAX_TIMELINES];
   439		struct fence_chain *chain, *signaler;
   440		int i, err = 0, count = 0;
   441		struct dma_fence *last;
   442	
   443		//signaler will signal the points in timelines;
   444		allocate_chains(&ci, 1, 21);
   445		signaler = ci.chains[0];
   446	
   447		dma_fence_get(&signaler->fence);
   448		for (i = 0;i < MAX_TIMELINES; i++) {
   449			s[i] = timeline(i, 0x0);
   450			drm_syncobj_replace_fence(s[i]->syncobj, &signaler->fence);
   451			tsk = kthread_run(__signal_timeline, s[i], "signal");
   452			if (IS_ERR(tsk)) {
   453				err = PTR_ERR(tsk);
   454				goto err;
   455			}
   456			get_task_struct(tsk);
   457			yield_to(tsk, true);
   458			tasks[count++] = tsk;
   459		}
   460	
   461		atomic_set(&signaler->signalers, MAX_TIMELINES);
   462		for (i = 0;i < MAX_TIMELINES; i++) {
   463	
   464			allocate_chains(&c[i], 1, i);
   465			t[i] = timeline(i, 0x0);
   466			chain = c[i].chains[0];
   467	
   468			drm_syncobj_replace_fence(t[i]->syncobj,
   469						  dma_fence_get(&chain->fence));
   470			last = &chain->chain.base;
   471			dma_fence_add_callback(t[i]->syncobj->fence,
   472						&signaler->cb,
   473						fence_callback);
   474			tsk = kthread_run(__wait_timeline, t[i], "wait");
   475			if (IS_ERR(tsk)) {
   476				err = PTR_ERR(tsk);
   477				goto err;
   478			}
   479			get_task_struct(tsk);
   480			yield_to(tsk, true);
   481			tasks[count++] = tsk;
   482		}
   483	
   484		dma_fence_wait(last, true);
   485		dma_fence_wait(&signaler->fence, true);
   486		dma_fence_put(&signaler->fence);
   487	err:
   488		for (i = 0;i < count; i++) {
   489			int ret;
   490	
   491			ret = kthread_stop(tasks[i]);
   492			if (ret && !err)
   493				err = ret;
   494			put_task_struct(tasks[i]);
   495		}
   496	
   497		for (i = 0; i < MAX_TIMELINES; i++) {
   498			chain = c[i].chains[0];
   499	
   500			if (!dma_fence_get_status(&chain->chain.base) ||
   501			    !dma_fence_get_status(&chain->fence)) {
   502				pr_err("Freeing an unsignaled fence\n");
   503				err = -1;
   504			}
   505			delete_chains(&c[i]);
   506			kmem_cache_free(slab_timeline, t[i]);
   507			kmem_cache_free(slab_timeline, s[i]);
   508		}
   509		delete_chains(&ci);
   510		return err;
 > 511	}
   512	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 60764 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20200411/49b66068/attachment-0001.gz>