[Intel-gfx] [PATCH 27/44] drm/tidss: Use devm_drm_dev_alloc

[Jyri Sarha]

On 03/04/2020 16:58, Daniel Vetter wrote:
> Already using devm_drm_dev_init, so very simple replacment.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> Cc: Jyri Sarha <jsarha at ti.com>
> Cc: Tomi Valkeinen <tomi.valkeinen at ti.com>

Tested-by: Jyri Sarha <jsarha at ti.com>

> ---
>  drivers/gpu/drm/tidss/tidss_drv.c | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c
> index ad449d104306..7d4465d58be8 100644
> --- a/drivers/gpu/drm/tidss/tidss_drv.c
> +++ b/drivers/gpu/drm/tidss/tidss_drv.c
> @@ -135,20 +135,13 @@ static int tidss_probe(struct platform_device *pdev)
>  
>  	dev_dbg(dev, "%s\n", __func__);
>  
> -	/* Can't use devm_* since drm_device's lifetime may exceed dev's */
> -	tidss = kzalloc(sizeof(*tidss), GFP_KERNEL);
> -	if (!tidss)
> -		return -ENOMEM;
> +	tidss = devm_drm_dev_alloc(&pdev->dev, &tidss_driver,
> +				   struct tidss_device, ddev);
> +	if (IS_ERR(tidss))
> +		return PTR_ERR(tidss);
>  
>  	ddev = &tidss->ddev;
>  
> -	ret = devm_drm_dev_init(&pdev->dev, ddev, &tidss_driver);
> -	if (ret) {
> -		kfree(ddev);
> -		return ret;
> -	}
> -	drmm_add_final_kfree(ddev, tidss);
> -
>  	tidss->dev = dev;
>  	tidss->feat = of_device_get_match_data(dev);
>  
> 


-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki