[Intel-gfx] [PATCH v2] drm/i915: Add missing deinitialization cases of load failure

Souza, Jose jose.souza at intel.com
Thu Apr 16 19:10:13 UTC 2020


On Wed, 2020-04-15 at 20:36 +0100, Chris Wilson wrote:
> Quoting José Roberto de Souza (2020-04-15 20:14:08)
> > +       i915_reset_error_state(i915);
> 
> If you are bored, we should move this to unregister as that is the
> last
> point at which it can be accessed from userspace. Hopefully I
> remember
> next time we are rearranging this sequence.

What if some error happen up to i915_gem_driver_remove()? We would leak
a i915_gpu_coredump.

Looks to me that i915_reset_error_state() should be
called after i915_gem_driver_remove().


> -Chris


More information about the Intel-gfx mailing list