[Intel-gfx] [v6] drm/i915/display: Enable DP Display Audio WA

Chris Wilson chris at chris-wilson.co.uk
Fri Apr 17 16:53:20 UTC 2020


Quoting Shankar, Uma (2020-04-17 12:49:21)
> 
> 
> > -----Original Message-----
> > From: Shankar, Uma <uma.shankar at intel.com>
> > Sent: Thursday, April 16, 2020 4:24 PM
> > To: intel-gfx at lists.freedesktop.org
> > Cc: Vehmanen, Kai <kai.vehmanen at intel.com>; Gupta, Anshuman
> > <anshuman.gupta at intel.com>; jani.nikula at linux.intel.com; Shankar, Uma
> > <uma.shankar at intel.com>
> > Subject: [v6] drm/i915/display: Enable DP Display Audio WA
> > 
> > For certain DP VDSC bpp settings, hblank asserts before hblank_early, leading to a
> > bad audio state. Driver need to program "hblank early enable" and "samples per line"
> > parameters in AUDIO_CONFIG_BE register.
> > 
> > This is Display Audio WA #1406928334 for 4k+VDSC usecase applicable on DP
> > encoders. Implemented the same.
> > 
> > v2: Fixed build failures on 32bit machine.
> > 
> > v3: Dropped u64, added helpers for sample room calculation,
> >     other general comments as per Jani Nikula's feedback.
> >     Also fixed connector type check (spotted by Anshuman)
> > 
> > v4: Addressed Jani Nikula and Kai's review comments.
> > 
> > v5: Addressed Anshuman's review comment and used crtc_* variable
> >     to get timings.
> > 
> > v6: Dropped a redundant initialization.
> 
> Change pushed to dinq. Thanks for the review.

You pushed even though it was failing in boot?

Please fix or revert.
-Chris


More information about the Intel-gfx mailing list