[Intel-gfx] [PATCH 3/4] drm/i915: Push TRANS_DDI_FUNC_CTL into the encoder->enable() hook

Chris Wilson chris at chris-wilson.co.uk
Fri Apr 17 19:51:35 UTC 2020


Quoting Ville Syrjala (2020-04-17 14:47:19)
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Push the TRANS_DDI_FUNC_CTL into the encoder enable hook. The disable
> is already there, and as a followup will enable us to pass the encoder
> all the way down.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

In intel_ddi_transcoder_func_reg_val_get() I found a list of ddi
crtc types (HDMI, ANALOG, DP_MST, DP_SST). Now hdmi/dp == ddi, and so we
are left with dp_mst and crt callbacks.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Is it possible to have more BUG_ON(!transcoder_is_ddi()) scatter around
the entry points?
-Chris


More information about the Intel-gfx mailing list