[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Asynchronous flip implementation for i915 (rev2)

Patchwork patchwork at emeril.freedesktop.org
Mon Apr 20 10:06:37 UTC 2020


== Series Details ==

Series: Asynchronous flip implementation for i915 (rev2)
URL   : https://patchwork.freedesktop.org/series/74386/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ae7aa012537f drm/i915: Add enable/disable flip done and flip done handler
3c944ffc2524 drm/i915: Add support for async flips in I915
5c51d5526531 drm/i915: Enable async flips in i915
65949de8f695 drm/i915: Make commit call blocking in case of async flips
bf1d60193151 drm/i915: Add checks specific to async flips
-:61: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'old_plane_state->color_plane[0].x !=
 		     new_plane_state->color_plane[0].x'
#61: FILE: drivers/gpu/drm/i915/display/intel_display.c:14706:
+		if ((old_plane_state->color_plane[0].x !=
+		     new_plane_state->color_plane[0].x) ||
+		    (old_plane_state->color_plane[0].y !=
+		     new_plane_state->color_plane[0].y)) {

-:61: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'old_plane_state->color_plane[0].y !=
 		     new_plane_state->color_plane[0].y'
#61: FILE: drivers/gpu/drm/i915/display/intel_display.c:14706:
+		if ((old_plane_state->color_plane[0].x !=
+		     new_plane_state->color_plane[0].x) ||
+		    (old_plane_state->color_plane[0].y !=
+		     new_plane_state->color_plane[0].y)) {

total: 0 errors, 0 warnings, 2 checks, 71 lines checked
c2228f5dc3a5 drm/i915: Do not call drm_crtc_arm_vblank_event in async flips



More information about the Intel-gfx mailing list