[Intel-gfx] [PATCH 1/2] drm/i915/hdmi: Get digital_port only once in intel_ddi_pre_enable_hdmi()

[Imre Deak]

On Wed, Apr 22, 2020 at 12:40:01PM -0700, José Roberto de Souza wrote:
> Getting it only once also removing intel_hdmi that is used only once
> and can be easily accessed by dig_port->hdmi.
> 
> Signed-off-by: José Roberto de Souza <jose.souza at intel.com>

Reviewed-by: Imre Deak <imre.deak at intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_ddi.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index c086ae5eb12f..255dc796ede5 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -3310,13 +3310,11 @@ static void intel_ddi_pre_enable_hdmi(struct intel_atomic_state *state,
>  				      const struct intel_crtc_state *crtc_state,
>  				      const struct drm_connector_state *conn_state)
>  {
> -	struct intel_digital_port *intel_dig_port = enc_to_dig_port(encoder);
> -	struct intel_hdmi *intel_hdmi = &intel_dig_port->hdmi;
>  	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> -	int level = intel_ddi_hdmi_level(encoder);
>  	struct intel_digital_port *dig_port = enc_to_dig_port(encoder);
> +	int level = intel_ddi_hdmi_level(encoder);
>  
> -	intel_dp_dual_mode_set_tmds_output(intel_hdmi, true);
> +	intel_dp_dual_mode_set_tmds_output(&dig_port->hdmi, true);
>  	intel_ddi_clk_select(encoder, crtc_state);
>  
>  	intel_display_power_get(dev_priv, dig_port->ddi_io_power_domain);
> @@ -3341,9 +3339,8 @@ static void intel_ddi_pre_enable_hdmi(struct intel_atomic_state *state,
>  
>  	intel_ddi_enable_pipe_clock(encoder, crtc_state);
>  
> -	intel_dig_port->set_infoframes(encoder,
> -				       crtc_state->has_infoframe,
> -				       crtc_state, conn_state);
> +	dig_port->set_infoframes(encoder, crtc_state->has_infoframe, crtc_state,
> +				 conn_state);
>  }
>  
>  static void intel_ddi_pre_enable(struct intel_atomic_state *state,
> -- 
> 2.26.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx