[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] drm/i915: Add engine scratch register to live_lrc_fixed

Patchwork patchwork at emeril.freedesktop.org
Thu Apr 23 19:07:51 UTC 2020


== Series Details ==

Series: series starting with [1/6] drm/i915: Add engine scratch register to live_lrc_fixed
URL   : https://patchwork.freedesktop.org/series/76406/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
56bad9b0154e drm/i915: Add engine scratch register to live_lrc_fixed
a124f376897f drm/i915: Add context batchbuffers to live_lrc_fixed
af7593329e65 drm/i915: Make define for lrc state offset
60f8ab766dee drm/i915: Add per ctx batchbuffer wa for timestamp
-:48: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#48: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:141:
+#define   MI_LRI_LRM_CS_MMIO		(1<<19)
                             		  ^

-:56: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#56: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:158:
+#define   MI_LRM_ASYNC			(1<<21)
                       			  ^

-:195: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#195: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:3233:
+			 I915_GTT_PAGE_SIZE/sizeof(*cs));
 			                   ^

-:232: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#232: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:3282:
+
+	}

total: 0 errors, 0 warnings, 4 checks, 248 lines checked
ffc915459ec7 drm/i915: Add live selftests for indirect ctx batchbuffers
-:53: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#53: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5733:
+#define CTX_BB_CANARY_OFFSET (3*1024)
                                ^

-:54: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#54: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5734:
+#define CTX_BB_CANARY_INDEX  (CTX_BB_CANARY_OFFSET/sizeof(u32))
                                                   ^

-:168: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#168: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5848:
+	for_each_engine(engine, gt, id) {
+

total: 0 errors, 0 warnings, 3 checks, 168 lines checked
4c1c50cfa325 drm/i915: Use indirect ctx bb to mend CMD_BUF_CCTL
-:24: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#24: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:517:
+#define END(total_state_size) 0, (total_state_size)

-:32: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#32: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:925:
+	NOP(3+9+1),
 	     ^

-:32: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#32: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:925:
+	NOP(3+9+1),
 	       ^

total: 1 errors, 0 warnings, 2 checks, 140 lines checked



More information about the Intel-gfx mailing list