[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Add engine scratch register to live_lrc_fixed (rev3)

Patchwork patchwork at emeril.freedesktop.org
Fri Apr 24 18:06:54 UTC 2020


== Series Details ==

Series: series starting with [1/4] drm/i915: Add engine scratch register to live_lrc_fixed (rev3)
URL   : https://patchwork.freedesktop.org/series/76443/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
48f89e7502e0 drm/i915: Add engine scratch register to live_lrc_fixed
c24957004e6a drm/i915: Add per ctx batchbuffer wa for timestamp
-:152: CHECK:SPACING: spaces preferred around that '*' (ctx:VxW)
#152: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:3246:
+	*cs++ = lrc_offset + (lrc_ring_gpr0(ce->engine) + 1)* sizeof(u32);
 	                                                    ^

-:190: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#190: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:3284:
+			 I915_GTT_PAGE_SIZE/sizeof(*cs));
 			                   ^

-:224: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#224: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:3330:
+
+	}

total: 0 errors, 0 warnings, 3 checks, 249 lines checked
433caccc67a1 drm/i915: Add live selftests for indirect ctx batchbuffers
-:55: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#55: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5733:
+#define CTX_BB_CANARY_OFFSET (3*1024)
                                ^

-:56: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#56: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5734:
+#define CTX_BB_CANARY_INDEX  (CTX_BB_CANARY_OFFSET/sizeof(u32))
                                                   ^

-:170: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#170: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5848:
+	for_each_engine(engine, gt, id) {
+

total: 0 errors, 0 warnings, 3 checks, 163 lines checked
b9ae36b10e73 drm/i915: Use indirect ctx bb to mend CMD_BUF_CCTL
-:42: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#42: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:619:
+#define END(total_state_size) 0, (total_state_size)

-:50: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#50: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1027:
+	NOP(3+9+1),
 	     ^

-:50: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#50: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1027:
+	NOP(3+9+1),
 	       ^

-:127: CHECK:SPACING: spaces preferred around that '*' (ctx:VxW)
#127: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:3327:
+	*cs++ = lrc_offset + (lrc_ring_cmd_buf_cctl(ce->engine) + 1)* sizeof(u32);
 	                                                            ^

total: 1 errors, 0 warnings, 3 checks, 160 lines checked



More information about the Intel-gfx mailing list