[Intel-gfx] [patch] drm/i915: Remove dubious Valleyview PCI IDs

Ville Syrjälä ville.syrjala at linux.intel.com
Tue Apr 28 14:09:31 UTC 2020


On Mon, Apr 27, 2020 at 11:47:52PM -0400, Alexei Podtelezhnikov wrote:
> 0x0155 is rather Ivy Bridge PCI-E Root Port.

A bit surprising we've not had any reports of the driver biding to the
wrong device.

> 0x0157 from the same commit ff049b6ce21d2814451afd4a116d001712e0116b
> is likely wrong too. Nowhere is it independetly confirmed or mentioned.

Can' find these in the spec so they do seem bogus. Also can't remember
ever seeing one of these.

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

> 
> Signed-off-by: Alexei Podtelezhnikov <apodtele at gmail.com>
> ---
>  include/drm/i915_pciids.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/i915_pciids.h b/src/i915_pciids.h
> index 1d2c1221..a9c88eab 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -258,9 +284,7 @@ Remove wrong and non-existent devices
>  	INTEL_VGA_DEVICE(0x0f30, info), \
>  	INTEL_VGA_DEVICE(0x0f31, info), \
>  	INTEL_VGA_DEVICE(0x0f32, info), \
> -	INTEL_VGA_DEVICE(0x0f33, info), \
> -	INTEL_VGA_DEVICE(0x0157, info), \
> -	INTEL_VGA_DEVICE(0x0155, info)
> +	INTEL_VGA_DEVICE(0x0f33, info)
>  
>  #define INTEL_BDW_ULT_GT1_IDS(info) \
>  	INTEL_VGA_DEVICE(0x1606, info), /* GT1 ULT */ \
> --
> 2.26.2
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel


More information about the Intel-gfx mailing list