[Intel-gfx] [PATCH] drm/i915/tgl: Wa_1607138340

Chris Wilson chris at chris-wilson.co.uk
Mon Aug 3 13:20:17 UTC 2020


From: Mika Kuoppala <mika.kuoppala at linux.intel.com>

Avoid possible cs hang with semaphores by disabling lite restore.

References: 921f0c47f228 ("drm/i915: Revert "drm/i915/tgl: Wa_1607138340"")
Signed-off-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
Cc: Tony Ye <tony.ye at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
---
Let's give this another spin. The hangs are still occuring on tgl-b0.
---
 drivers/gpu/drm/i915/gt/intel_lrc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index f1067806e8d8..80dae2f298ba 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -1504,6 +1504,10 @@ static u64 execlists_update_context(struct i915_request *rq)
 	 */
 	wmb();
 
+	/* Wa_1607138340:tgl */
+	if (IS_TGL_REVID(rq->engine->i915, TGL_REVID_A0, TGL_REVID_B0))
+		desc |= CTX_DESC_FORCE_RESTORE;
+
 	ce->lrc.desc &= ~CTX_DESC_FORCE_RESTORE;
 	return desc;
 }
-- 
2.20.1



More information about the Intel-gfx mailing list