[Intel-gfx] [PATCH] drm/i915: Fix wrong return value in intel_atomic_check()

[Souza, Jose]

On Sun, 2020-08-02 at 19:15 +0800, Tianjia Zhang wrote:
> In the case of calling check_digital_port_conflicts() failed, a
> negative error code -EINVAL should be returned.

Reviewed-by: José Roberto de Souza <jose.souza at intel.com>

> 
> Fixes: bf5da83e4bd80 ("drm/i915: Move check_digital_port_conflicts() earier")
> Cc: Ville Syrjälä <
> ville.syrjala at linux.intel.com
> >
> Signed-off-by: Tianjia Zhang <
> tianjia.zhang at linux.alibaba.com
> >
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 26996e1839e2..9f3a7ef58aba 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -14872,7 +14872,7 @@ static int intel_atomic_check(struct drm_device *dev,
>  	if (any_ms && !check_digital_port_conflicts(state)) {
>  		drm_dbg_kms(&dev_priv->drm,
>  			    "rejecting conflicting digital port configuration\n");
> -		ret = EINVAL;
> +		ret = -EINVAL;
>  		goto fail;
>  	}
>  
>