[Intel-gfx] [igt-dev] [PATCH i-g-t] lib: Use unsigned gen for forward compatible tests

Petri Latvala petri.latvala at intel.com
Mon Aug 10 08:22:42 UTC 2020


On Mon, Aug 10, 2020 at 10:09:46AM +0200, Zbigniew Kempczyński wrote:
> On Thu, Aug 06, 2020 at 03:45:29PM +0100, Chris Wilson wrote:
> > Unknown, so future, gen are marked as -1 which we want to treat as -1u
> > so that always pass >= gen checks.
> 
> Do we really want to enable the tests when platform is not fully
> enabled in IGT?

What does "fully enabled" mean?

If the test is checking for just "gen > x", the test should work
already. If the test is also checking for "gen < y" then we get a
spurious failure, but either way CI is going to tell you that
something is not passing. Without this it will be a skip, along with
skipping in the case that should just work already without actual test
changes.


-- 
Petri Latvala


More information about the Intel-gfx mailing list