[Intel-gfx] [PATCH] drm/i915/gt:fix raw-wakeref not held calltrace in vGPU

Zhenyu Wang zhenyuw at linux.intel.com
Tue Aug 11 08:39:09 UTC 2020


On 2020.08.11 09:26:11 +0100, Chris Wilson wrote:
> Quoting Yan Zhao (2020-08-11 04:02:09)
> > UNCORE_HAS_FORCEWAKE is not turned on when intel_vgpu_active() returns
> > true, so the guest mmio writes go to gen2_write32().
> 
> The vgpu writes are just memory traps, the device wakeref should not be
> required. It seems like we've accidentally added the assert to the wrong
> io accessors.

yeah, I agree. I did remember we didn't have that assert before for
vgpu case... maybe better hook with explicit vgpu_read()/vgpu_write()
that won't be affected by other changes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20200811/4e63e4f6/attachment.sig>


More information about the Intel-gfx mailing list