[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/modeset-lock: Take the modeset BKL for legacy drivers
Patchwork
patchwork at emeril.freedesktop.org
Fri Aug 14 09:47:32 UTC 2020
== Series Details ==
Series: drm/modeset-lock: Take the modeset BKL for legacy drivers
URL : https://patchwork.freedesktop.org/series/80620/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
4be15a75c756 drm/modeset-lock: Take the modeset BKL for legacy drivers
-:8: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9bcaa3fe58ab ("drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers")'
#8:
commit 9bcaa3fe58ab7559e71df798bcff6e0795158695
-:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12:
drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers
-:176: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#176: FILE: include/drm/drm_modeset_lock.h:194:
+#define DRM_MODESET_LOCK_ALL_END(dev, ctx, ret) \
modeset_lock_fail: \
if (ret == -EDEADLK) { \
ret = drm_modeset_backoff(&ctx); \
-:176: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ctx' may be better as '(ctx)' to avoid precedence issues
#176: FILE: include/drm/drm_modeset_lock.h:194:
+#define DRM_MODESET_LOCK_ALL_END(dev, ctx, ret) \
modeset_lock_fail: \
if (ret == -EDEADLK) { \
ret = drm_modeset_backoff(&ctx); \
-:176: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ret' - possible side-effects?
#176: FILE: include/drm/drm_modeset_lock.h:194:
+#define DRM_MODESET_LOCK_ALL_END(dev, ctx, ret) \
modeset_lock_fail: \
if (ret == -EDEADLK) { \
ret = drm_modeset_backoff(&ctx); \
-:176: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ret' may be better as '(ret)' to avoid precedence issues
#176: FILE: include/drm/drm_modeset_lock.h:194:
+#define DRM_MODESET_LOCK_ALL_END(dev, ctx, ret) \
modeset_lock_fail: \
if (ret == -EDEADLK) { \
ret = drm_modeset_backoff(&ctx); \
-:189: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 2 errors, 2 warnings, 3 checks, 111 lines checked
More information about the Intel-gfx
mailing list