[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

Patchwork patchwork at emeril.freedesktop.org
Sun Aug 30 13:25:57 UTC 2020


== Series Details ==

Series: acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API
URL   : https://patchwork.freedesktop.org/series/81176/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
48148eeaab72 ACPI / LPSS: Resume Cherry Trail PWM controller in no-irq phase
45a4de251846 ACPI / LPSS: Save Cherry Trail PWM ctx registers only once (at activation)
4f7f933a6af6 pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare()
bea1f0a2539c pwm: lpss: Add range limit check for the base_unit register value
c14d8f448f41 pwm: lpss: Add pwm_lpss_prepare_enable() helper
-:45: CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#45: FILE: drivers/pwm/pwm-lpss.c:137:
+	pwm_lpss_cond_enable(pwm, enable && lpwm->info->bypass == false);

-:50: CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#50: FILE: drivers/pwm/pwm-lpss.c:142:
+	pwm_lpss_cond_enable(pwm, enable && lpwm->info->bypass == true);

total: 0 errors, 0 warnings, 2 checks, 67 lines checked
4537cd716e11 pwm: lpss: Use pwm_lpss_restore() when restoring state on resume
a12337a38581 pwm: lpss: Always update state and set update bit
23074c82455a pwm: crc: Fix period / duty_cycle times being off by a factor of 256
d6a64ac9e222 pwm: crc: Fix off-by-one error in the clock-divider calculations
3eaa398d8d92 pwm: crc: Fix period changes not having any effect
605d467e4d8d pwm: crc: Enable/disable PWM output on enable/disable
8924b6bba39e pwm: crc: Implement apply() method to support the new atomic PWM API
32379b451d32 pwm: crc: Implement get_state() method
ada5a0b67cad drm/i915: panel: Add get_vbt_pwm_freq() helper
b09d3cbb410b drm/i915: panel: Honor the VBT PWM frequency for devs with an external PWM controller
823d349c8754 drm/i915: panel: Honor the VBT PWM min setting for devs with an external PWM controller
263c2d7f2378 drm/i915: panel: Use atomic PWM API for devs with an external PWM controller




More information about the Intel-gfx mailing list