[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/12] drm/i915/gem: Drop free_work for GEM contexts

Patchwork patchwork at emeril.freedesktop.org
Tue Dec 1 09:34:57 UTC 2020


== Series Details ==

Series: series starting with [01/12] drm/i915/gem: Drop free_work for GEM contexts
URL   : https://patchwork.freedesktop.org/series/84440/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
4f351702b028 drm/i915/gem: Drop free_work for GEM contexts
9fc9fb916f26 drm/i915/gt: Track the overall awake/busy time
7d7adb951b35 drm/i915: Expose list of clients in sysfs
-:84: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#84: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 384 lines checked
ee050c119037 drm/i915: Update client name on context create
-:213: WARNING:BRACES: braces {} are not necessary for single statement blocks
#213: FILE: drivers/gpu/drm/i915/i915_drm_client.c:247:
+	if (name->pid != rcu_dereference_protected(client->name, true)->pid) {
+		name = rcu_replace_pointer(client->name, name, true);
+	}

total: 0 errors, 1 warnings, 0 checks, 208 lines checked
dff72485e95b drm/i915: Make GEM contexts track DRM clients
dc11141234a3 drm/i915: Track runtime spent in closed and unreachable GEM contexts
d3d5619fc9fb drm/i915: Track all user contexts per client
73cf39079d77 drm/i915: Track context current active time
-:132: WARNING:LINE_SPACING: Missing a blank line after declarations
#132: FILE: drivers/gpu/drm/i915/gt/intel_context_types.h:113:
+			u32 last;
+			I915_SELFTEST_DECLARE(u32 num_underflow);

total: 0 errors, 1 warnings, 0 checks, 238 lines checked
44dd43e81326 drm/i915: Prefer software tracked context busyness
56632b583933 drm/i915: Look up clients by pid
-:175: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#175: FILE: drivers/gpu/drm/i915/i915_drm_client.h:32:
+	spinlock_t pid_lock;

total: 0 errors, 0 warnings, 1 checks, 176 lines checked
241fa69b1882 proc: Show GPU runtimes
-:35: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
#35: FILE: fs/proc/base.c:3266:
+	ONE("gpu", S_IRUGO, proc_pid_gpu),

-:43: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
#43: FILE: fs/proc/base.c:3596:
+	ONE("gpu", S_IRUGO, proc_pid_gpu),

-:48: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 3 warnings, 0 checks, 149 lines checked
e3a6135246e4 drm/i915/gt: Export device and per-process runtimes via procfs
-:54: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

-:78: WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#78: FILE: drivers/gpu/drm/i915/gt/intel_gt_proc.c:20:
+	BUILD_BUG_ON(MAX_ENGINE_CLASS >= ARRAY_SIZE(rt->channel));

total: 0 errors, 2 warnings, 0 checks, 125 lines checked




More information about the Intel-gfx mailing list