[Intel-gfx] [PATCH v3] drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking

[Tvrtko Ursulin]

On 01/12/2020 13:23, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2020-12-01 13:17:57)
>> diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
>> index fa1f3d62f9a6..6edcb2b6c708 100644
>> --- a/include/uapi/drm/i915_drm.h
>> +++ b/include/uapi/drm/i915_drm.h
>> @@ -178,7 +178,7 @@ enum drm_i915_pmu_engine_sample {
>>   #define I915_PMU_INTERRUPTS            __I915_PMU_OTHER(2)
>>   #define I915_PMU_RC6_RESIDENCY         __I915_PMU_OTHER(3)
>>   
>> -#define I915_PMU_LAST I915_PMU_RC6_RESIDENCY
>> +#define I915_PMU_LAST /* Deprecated - do not use */ I915_PMU_RC6_RESIDENCY
> 
> Do we still update the value, or let it rot?

Rot for a while and then zap was my plan. As soon as I wean perf_pmu of 
it. Too bold and reckless?

Regards,

Tvrtko