[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for Intel's eDP backlight controls (rev3)

Patchwork patchwork at emeril.freedesktop.org
Fri Dec 4 22:46:58 UTC 2020


== Series Details ==

Series: drm/i915: Add support for Intel's eDP backlight controls (rev3)
URL   : https://patchwork.freedesktop.org/series/81702/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f28a72ff60f8 drm/i915/dp: Program source OUI on eDP panels
9233620226ff drm/i915: Rename pwm_* backlight callbacks to ext_pwm_*
f6028d739181 drm/i915: Pass down brightness values to enable/disable backlight callbacks
ae85f27764dd drm/i915: Keep track of pwm-related backlight hooks separately
9af1a6377bd0 drm/i915/dp: Rename eDP VESA backlight interface functions
e013bc041067 drm/i915/dp: Add register definitions for Intel HDR backlight interface
0f59b8d11611 drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)
-:151: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#151: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:147:
+			return panel->backlight.max;
+		} else {

-:172: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t'
#172: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:168:
+	uint8_t buf[4] = { 0 };

-:191: WARNING:LINE_SPACING: Missing a blank line after declarations
#191: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:187:
+		const u32 pwm_level = intel_panel_backlight_level_to_pwm(connector, level);
+		intel_panel_set_pwm_level(conn_state, pwm_level);

-:218: WARNING:LINE_SPACING: Missing a blank line after declarations
#218: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:214:
+		u32 pwm_level = intel_panel_backlight_level_to_pwm(connector, level);
+		panel->backlight.pwm_funcs->enable(crtc_state, conn_state, pwm_level);

total: 0 errors, 3 warnings, 1 checks, 379 lines checked
1cd0fee4656f drm/i915/dp: Allow forcing specific interfaces through enable_dpcd_backlight
0246c3bf43a0 drm/dp: Revert "drm/dp: Introduce EDID-based quirks"




More information about the Intel-gfx mailing list