[Intel-gfx] [PATCH] drm/i915/selftests: Improve error reporting for igt_mock_max_segment
Chris Wilson
chris at chris-wilson.co.uk
Mon Dec 7 13:03:46 UTC 2020
When we fail to find a single block large enough to require splitting,
report the largest block we did find.
Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld at intel.com>
Cc: Ramalingam C <ramalingam.c at intel.com>
---
.../gpu/drm/i915/selftests/intel_memory_region.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/intel_memory_region.c b/drivers/gpu/drm/i915/selftests/intel_memory_region.c
index a0b518c255de..a55079a061dd 100644
--- a/drivers/gpu/drm/i915/selftests/intel_memory_region.c
+++ b/drivers/gpu/drm/i915/selftests/intel_memory_region.c
@@ -384,16 +384,15 @@ static int igt_mock_max_segment(void *arg)
goto out_put;
}
- err = -EINVAL;
+ size = 0;
list_for_each_entry(block, &obj->mm.blocks, link) {
- if (i915_buddy_block_size(&mem->mm, block) > max_segment) {
- err = 0;
- break;
- }
+ if (i915_buddy_block_size(&mem->mm, block) > size)
+ size = i915_buddy_block_size(&mem->mm, block);
}
- if (err) {
- pr_err("%s: Failed to create a huge contiguous block\n",
- __func__);
+ if (size < max_segment) {
+ pr_err("%s: Failed to create a huge contiguous block [> %u], largest block %lld\n",
+ __func__, max_segment, size);
+ err = -EINVAL;
goto out_close;
}
--
2.20.1
More information about the Intel-gfx
mailing list