[Intel-gfx] [PATCH 01/20] drm/i915/gem: Drop false !i915_vma_is_closed assertion

[Tvrtko Ursulin]

On 07/12/2020 19:38, Chris Wilson wrote:
> Closed vma are protected by the GT wakeref held as we lookup the vma, so
> we know that the vma will not be freed as we process it for the execbuf.
> Instead we expect to catch the closed status of the context, and simply
> allow the close-race on an individual vma to be washed away.
> 
> Longer term, the GT wakeref protection will be removed by explicit
> vma.kref tracking.
> 
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2245
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index b07dc1156a0e..193996144c84 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -534,8 +534,6 @@ eb_add_vma(struct i915_execbuffer *eb,
>   	struct drm_i915_gem_exec_object2 *entry = &eb->exec[i];
>   	struct eb_vma *ev = &eb->vma[i];
>   
> -	GEM_BUG_ON(i915_vma_is_closed(vma));
> -
>   	ev->vma = vma;
>   	ev->exec = entry;
>   	ev->flags = entry->flags;
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko