[Intel-gfx] [PATCH] drm/i915/pmu: Stop peeking at kernel internals for counting interrupts

Chris Wilson chris at chris-wilson.co.uk
Thu Dec 10 18:29:31 UTC 2020


Quoting Tvrtko Ursulin (2020-12-10 17:35:45)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> Peeking at kernel internals is bad taste so instead we keep our own
> counter which also solves the problem of shared interrupt lines.
> 
> Additional cost should be way below noise relative to mmio reads.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Suggested-by: Thomas Gleixner <tglx at linutronix.de>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>

But this duplicates the same counting done by the core code. Which is
also in bad taste.
-Chris


More information about the Intel-gfx mailing list