[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Split logical ring contexts from execlist submission (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Dec 10 22:27:39 UTC 2020


== Series Details ==

Series: drm/i915/gt: Split logical ring contexts from execlist submission (rev2)
URL   : https://patchwork.freedesktop.org/series/84752/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
454579934182 drm/i915/gt: Split logical ring contexts from execlist submission
-:1747: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#1747: 
new file mode 100644

-:1776: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'count' - possible side-effects?
#1776: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:25:
+#define LRI(count, flags) ((flags) << 6 | (count) | BUILD_BUG_ON_ZERO(count >= BIT(6)))

-:1778: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#1778: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:27:
+#define REG(x) (((x) >> 2) | BUILD_BUG_ON_ZERO(x >= 0x200))

-:1779: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1779: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:28:
+#define REG16(x) \
+	(((x) >> 9) | BIT(7) | BUILD_BUG_ON_ZERO(x >= 0x10000)), \
+	(((x) >> 2) & 0x7f)

-:1779: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#1779: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:28:
+#define REG16(x) \
+	(((x) >> 9) | BIT(7) | BUILD_BUG_ON_ZERO(x >= 0x10000)), \
+	(((x) >> 2) & 0x7f)

-:1782: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1782: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:31:
+#define END(total_state_size) 0, (total_state_size)

-:2426: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2426: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:675:
+		lrc_setup_indirect_ctx(regs, engine,
+					    i915_ggtt_offset(wa_ctx->vma) +

-:5754: WARNING:MEMORY_BARRIER: memory barrier without comment
#5754: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:638:
+		wmb();

-:5783: WARNING:MEMORY_BARRIER: memory barrier without comment
#5783: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:667:
+	wmb();

-:5915: WARNING:MEMORY_BARRIER: memory barrier without comment
#5915: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:799:
+		wmb();

-:6463: WARNING:MEMORY_BARRIER: memory barrier without comment
#6463: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:1347:
+	wmb();

-:6877: WARNING:LINE_SPACING: Missing a blank line after declarations
#6877: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:1761:
+	struct i915_request *rq;
+	IGT_TIMEOUT(end_time);

total: 2 errors, 6 warnings, 4 checks, 5153 lines checked




More information about the Intel-gfx mailing list