[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gt: Split logical ring contexts from execlist submission

Patchwork patchwork at emeril.freedesktop.org
Tue Dec 15 02:46:15 UTC 2020


== Series Details ==

Series: series starting with [1/2] drm/i915/gt: Split logical ring contexts from execlist submission
URL   : https://patchwork.freedesktop.org/series/84930/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b43f0b75f3e2 drm/i915/gt: Split logical ring contexts from execlist submission
-:1796: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#1796: 
new file mode 100644

-:1825: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'count' - possible side-effects?
#1825: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:25:
+#define LRI(count, flags) ((flags) << 6 | (count) | BUILD_BUG_ON_ZERO(count >= BIT(6)))

-:1827: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#1827: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:27:
+#define REG(x) (((x) >> 2) | BUILD_BUG_ON_ZERO(x >= 0x200))

-:1828: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1828: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:28:
+#define REG16(x) \
+	(((x) >> 9) | BIT(7) | BUILD_BUG_ON_ZERO(x >= 0x10000)), \
+	(((x) >> 2) & 0x7f)

-:1828: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#1828: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:28:
+#define REG16(x) \
+	(((x) >> 9) | BIT(7) | BUILD_BUG_ON_ZERO(x >= 0x10000)), \
+	(((x) >> 2) & 0x7f)

-:1831: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1831: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:31:
+#define END(total_state_size) 0, (total_state_size)

-:5791: WARNING:MEMORY_BARRIER: memory barrier without comment
#5791: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:638:
+		wmb();

-:5820: WARNING:MEMORY_BARRIER: memory barrier without comment
#5820: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:667:
+	wmb();

-:5952: WARNING:MEMORY_BARRIER: memory barrier without comment
#5952: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:799:
+		wmb();

-:6500: WARNING:MEMORY_BARRIER: memory barrier without comment
#6500: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:1347:
+	wmb();

-:6914: WARNING:LINE_SPACING: Missing a blank line after declarations
#6914: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:1761:
+	struct i915_request *rq;
+	IGT_TIMEOUT(end_time);

total: 2 errors, 6 warnings, 3 checks, 5221 lines checked
35c99bde3b21 drm/i915/gt: Provide a utility to create a scratch buffer




More information about the Intel-gfx mailing list