[Intel-gfx] [PATCH] drm/i915/audio: Skip the cdclk modeset if no pipes attached

[Chris Wilson]

Quoting Ville Syrjälä (2020-02-03 13:23:17)
> On Sat, Feb 01, 2020 at 09:46:41AM +0000, Chris Wilson wrote:
> > -static int glk_force_audio_cdclk_commit(struct intel_atomic_state *state,
> > +static int glk_force_audio_cdclk_commit(struct intel_crtc *crtc,
> > +                                     struct intel_atomic_state *state,
> >                                       bool enable)
> >  {
> > -     struct drm_i915_private *dev_priv = to_i915(state->base.dev);
> >       struct intel_cdclk_state *cdclk_state;
> > -     struct intel_crtc *crtc;
> >       int ret;
> >  
> >       /* need to hold at least one crtc lock for the global state */
> > -     crtc = intel_get_crtc_for_pipe(dev_priv, PIPE_A);
> 
> Was thinking a simple 'return 0' would do the trick, but maybe we
> don't want to call this at all. OTOH not sure why we would even
> register the audio component if there are no pipes. Does the audio
> driver get confused if we don't do that?

I expect that is the most correct answer: don't register display audio
if the display insists on there being no pipes. I'll leave that to the
intrepid observers though :)
-Chris