[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Stop using mutex while sending CTB messages (rev4)

Patchwork patchwork at emeril.freedesktop.org
Mon Feb 3 15:04:04 UTC 2020


== Series Details ==

Series: drm/i915/guc: Stop using mutex while sending CTB messages (rev4)
URL   : https://patchwork.freedesktop.org/series/72827/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
7a2d3a071119 drm/i915/guc: Stop using mutex while sending CTB messages
-:385: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#385: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h:36:
+	spinlock_t lock;

-:415: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'lock' - possible side-effects?
#415: FILE: drivers/gpu/drm/i915/i915_utils.h:455:
+#define lockdep_set_subclass_and_mark_as_used(lock, sub, irq_off) \
+	do { \
+		lockdep_set_subclass((lock), (sub)); \
+		if (irq_off) \
+			local_irq_disable(); \
+		might_lock((lock)); \
+		if (irq_off) \
+			local_irq_enable(); \
+	} while (0)

-:415: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'irq_off' - possible side-effects?
#415: FILE: drivers/gpu/drm/i915/i915_utils.h:455:
+#define lockdep_set_subclass_and_mark_as_used(lock, sub, irq_off) \
+	do { \
+		lockdep_set_subclass((lock), (sub)); \
+		if (irq_off) \
+			local_irq_disable(); \
+		might_lock((lock)); \
+		if (irq_off) \
+			local_irq_enable(); \
+	} while (0)

total: 0 errors, 0 warnings, 3 checks, 346 lines checked



More information about the Intel-gfx mailing list