[Intel-gfx] [PATCH] drm/i915/selftest: Ensure string fits within name[]

[Mika Kuoppala]

Chris Wilson <chris at chris-wilson.co.uk> writes:

> Shrink the strncpy bounds to ensure the NUL-terminator can fit within
> the embedded array:
>
> In file included from drivers/gpu/drm/i915/gem/i915_gem_context.c:2475:
> drivers/gpu/drm/i915/gem/selftests/mock_context.c: In function ‘mock_context’:
> drivers/gpu/drm/i915/gem/selftests/mock_context.c:40:3: error: ‘strncpy’ specified bound 24 equals destination size [-Werror=stringop-truncation]
>    40 |   strncpy(ctx->name, name, sizeof(ctx->name));
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gem/selftests/mock_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.c b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> index 7bad8fed4238..81764289cf0d 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> @@ -37,7 +37,7 @@ mock_context(struct drm_i915_private *i915,
>  	if (name) {
>  		struct i915_ppgtt *ppgtt;
>  
> -		strncpy(ctx->name, name, sizeof(ctx->name));
> +		strncpy(ctx->name, name, sizeof(ctx->name) - 1);
>  
>  		ppgtt = mock_ppgtt(i915, name);
>  		if (!ppgtt)
> -- 
> 2.25.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx